mirror of
https://github.com/imdap/ruoyi-plus-vben5.git
synced 2026-04-23 00:38:34 +08:00
ccabbf0e97
* feat: enable project-scoped preferences extension tabs Add a typed extension schema so subprojects can define extra settings, render them in the shared preferences drawer only when configured, and consume them in playground as a real feature demo. Extension labels now follow locale keys instead of hardcoded app-specific strings. Constraint: Reuse the shared preferences drawer and field blocks Rejected: Add app-specific fields to core preferences | too tightly coupled Rejected: Inline localized label objects | breaks existing locale-key flow Confidence: high Scope-risk: moderate Reversibility: clean Directive: Keep extension labels as locale keys rendered via $t in UI Tested: Vitest preferences tests Tested: Turbo typecheck for preferences, layouts, web-antd, and playground Tested: ESLint for touched preferences and playground files Not-tested: Manual browser interaction in playground preferences drawer * fix: satisfy lint formatting for preferences extension demo Adjust the playground preferences extension demo template so formatter and Vue template lint rules agree on the rendered markup. This keeps CI green without changing runtime behavior. Constraint: Must preserve the existing demo behavior while fixing CI only Rejected: Disable the Vue newline rule | would weaken shared lint guarantees Confidence: high Scope-risk: narrow Reversibility: clean Directive: Prefer computed/template structures that avoid formatter-vs-lint conflicts Tested: pnpm run lint Not-tested: Manual browser interaction in playground preferences extension demo * fix: harden custom preferences validation and i18n labels Tighten custom preferences handling so numeric extension fields respect min, max, and step constraints. Number inputs now ignore NaN values, and web-antd extension metadata uses locale keys instead of raw strings. Also align tip-based hover guards in shared preference inputs/selects. Constraint: Keep fixes scoped to verified findings only Rejected: Broader refactor of preferences field components | not needed for these fixes Confidence: high Scope-risk: narrow Reversibility: clean Directive: Reuse the same validation path for updates and cache hydration Tested: Vitest preferences tests Tested: ESLint for touched preferences and widget files Tested: Typecheck for web-antd, layouts, and core preferences Not-tested: Manual browser interaction for all preference field variants * fix: remove localized default from playground extension config Drop the hardcoded Chinese default value from the playground extension report title field and fall back to an empty string instead. This keeps extension config locale-neutral while preserving localized labels and placeholders through translation keys. Constraint: Keep the fix limited to the verified localized default issue Rejected: Compute the default from runtime locale in config | unnecessary for this finding Confidence: high Scope-risk: narrow Reversibility: clean Directive: Avoid embedding localized literals in extension default values Tested: ESLint for playground/src/preferences.ts Tested: Oxfmt check for playground/src/preferences.ts Not-tested: Manual playground preferences interaction * docs: document project-scoped preferences extension workflow Add Chinese and English guide sections explaining how to define, initialize, read, and update project-scoped preferences extensions. Also document numeric field validation and point readers to the playground demo for a complete example. Constraint: Keep this docs-only and aligned with the shipped API Rejected: Update only Chinese docs | would leave English docs inconsistent Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep zh/en examples and playground demo paths synchronized Tested: git diff --check; pnpm build:docs Not-tested: Manual browser review of the rendered docs site * fix: harden custom preferences defaults and baselines Use a locale-neutral default for the web-antd report title. Also stop preference getters from exposing mutable baseline or extension schema objects, and add a regression test for external mutation attempts. Constraint: Keep behavior compatible with the shipped preferences API Rejected: Return raw refs with readonly typing only | callers could still mutate internals Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep defensive copies for baseline and schema getters unless storage semantics change Tested: eslint, oxlint, targeted vitest, filtered typecheck, git diff --check Not-tested: Full monorepo typecheck and test suite * test: relax custom preference cache key matching Avoid coupling the custom-number cache test to one exact localStorage key string. Match the intended cache lookup more loosely so the test still verifies filtering behavior without depending on the full namespaced cache key. Constraint: Focus the test on cache filtering behavior Rejected: Assert one exact key | brittle with namespace changes Confidence: high Scope-risk: narrow Reversibility: clean Directive: Prefer behavior tests over literal storage keys Tested: targeted vitest, eslint, git diff --check Not-tested: Full monorepo test suite --------- Co-authored-by: caisin <caisin@caisins-Mac-mini.local>
77 lines
1.7 KiB
Vue
77 lines
1.7 KiB
Vue
<script setup lang="ts">
|
|
import type { SelectOption } from '@vben/types';
|
|
|
|
import { useSlots } from 'vue';
|
|
|
|
import { CircleHelp } from '@vben/icons';
|
|
|
|
import {
|
|
Select,
|
|
SelectContent,
|
|
SelectItem,
|
|
SelectTrigger,
|
|
SelectValue,
|
|
VbenTooltip,
|
|
} from '@vben-core/shadcn-ui';
|
|
|
|
defineOptions({
|
|
name: 'PreferenceSelectItem',
|
|
});
|
|
|
|
withDefaults(
|
|
defineProps<{
|
|
disabled?: boolean;
|
|
items?: SelectOption[];
|
|
placeholder?: string;
|
|
tip?: string;
|
|
}>(),
|
|
{
|
|
disabled: false,
|
|
placeholder: '',
|
|
tip: '',
|
|
items: () => [],
|
|
},
|
|
);
|
|
|
|
const selectValue = defineModel<string>();
|
|
|
|
const slots = useSlots();
|
|
</script>
|
|
|
|
<template>
|
|
<div
|
|
:class="{
|
|
'hover:bg-accent': !(slots.tip || tip),
|
|
'pointer-events-none opacity-50': disabled,
|
|
}"
|
|
class="my-1 flex w-full items-center justify-between rounded-md px-2 py-1"
|
|
>
|
|
<span class="flex items-center text-sm">
|
|
<slot></slot>
|
|
|
|
<VbenTooltip v-if="slots.tip || tip" side="bottom">
|
|
<template #trigger>
|
|
<CircleHelp class="ml-1 size-3 cursor-help" />
|
|
</template>
|
|
<slot name="tip">
|
|
<template v-if="tip">
|
|
<p v-for="(line, index) in tip.split('\n')" :key="index">
|
|
{{ line }}
|
|
</p>
|
|
</template>
|
|
</slot>
|
|
</VbenTooltip>
|
|
</span>
|
|
<Select v-model="selectValue">
|
|
<SelectTrigger class="h-8 w-41.25">
|
|
<SelectValue :placeholder="placeholder" />
|
|
</SelectTrigger>
|
|
<SelectContent>
|
|
<template v-for="item in items" :key="item.value">
|
|
<SelectItem :value="item.value"> {{ item.label }} </SelectItem>
|
|
</template>
|
|
</SelectContent>
|
|
</Select>
|
|
</div>
|
|
</template>
|