From ac89329757e2252a2f3a21ec8df6d461ee8af2e7 Mon Sep 17 00:00:00 2001 From: backstraw Date: Tue, 1 Jul 2025 21:58:24 +0900 Subject: [PATCH] fix: close FileOutputStream to prevent resource leak in downloadFile --- .../main/java/io/dataease/utils/HttpClientUtil.java | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sdk/common/src/main/java/io/dataease/utils/HttpClientUtil.java b/sdk/common/src/main/java/io/dataease/utils/HttpClientUtil.java index 5734f39016..93a4af5069 100755 --- a/sdk/common/src/main/java/io/dataease/utils/HttpClientUtil.java +++ b/sdk/common/src/main/java/io/dataease/utils/HttpClientUtil.java @@ -397,11 +397,13 @@ public class HttpClientUtil { name.put("fileName", fileName); name.put("tranName", tranName); File localFile = new File(path + tranName); - FileOutputStream outputStream = new FileOutputStream(localFile); - byte[] buffer = new byte[4096]; - int bytesRead; - while ((bytesRead = response.getEntity().getContent().read(buffer)) != -1) { - outputStream.write(buffer, 0, bytesRead); + try (InputStream is = response.getEntity().getContent(); + FileOutputStream outputStream = new FileOutputStream(localFile)) { + byte[] buffer = new byte[4096]; + int bytesRead; + while ((bytesRead = is.read(buffer)) != -1) { + outputStream.write(buffer, 0, bytesRead); + } } } catch (Exception e) { logger.error("HttpClient查询失败", e);