From ebe1001f200cdc2cc473e92a60c1f88e49512418 Mon Sep 17 00:00:00 2001 From: shimingxy Date: Mon, 22 Dec 2025 14:23:46 +0800 Subject: [PATCH] Unnecessary path variable definition [WEB_ANNOTATION_NAMES] --- .../formbased/endpoint/FormBasedAuthorizeEndpoint.java | 2 +- .../passkey/endpoint/PasskeyRegistrationEndpoint.java | 10 +++++----- .../support/socialsignon/SocialSignOnEndpoint.java | 10 +++++----- .../apis/identity/rest/RestResourcesController.java | 2 +- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/dromara/maxkey/authz/formbased/endpoint/FormBasedAuthorizeEndpoint.java b/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/dromara/maxkey/authz/formbased/endpoint/FormBasedAuthorizeEndpoint.java index d2f45d375..7f33caf48 100644 --- a/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/dromara/maxkey/authz/formbased/endpoint/FormBasedAuthorizeEndpoint.java +++ b/maxkey-protocols/maxkey-protocol-formbased/src/main/java/org/dromara/maxkey/authz/formbased/endpoint/FormBasedAuthorizeEndpoint.java @@ -62,7 +62,7 @@ public class FormBasedAuthorizeEndpoint extends AuthorizeBaseEndpoint{ @RequestMapping("/authz/formbased/{id}") public ModelAndView authorize( HttpServletRequest request, - @PathVariable("id") String id, + @PathVariable String id, @CurrentUser UserInfo currentUser){ AppsFormBasedDetails formBasedDetails = formBasedDetailsService.getAppDetails(id , true); diff --git a/maxkey-starter/maxkey-starter-passkey/src/main/java/org/dromara/maxkey/passkey/endpoint/PasskeyRegistrationEndpoint.java b/maxkey-starter/maxkey-starter-passkey/src/main/java/org/dromara/maxkey/passkey/endpoint/PasskeyRegistrationEndpoint.java index f34125c56..e1c1128fb 100644 --- a/maxkey-starter/maxkey-starter-passkey/src/main/java/org/dromara/maxkey/passkey/endpoint/PasskeyRegistrationEndpoint.java +++ b/maxkey-starter/maxkey-starter-passkey/src/main/java/org/dromara/maxkey/passkey/endpoint/PasskeyRegistrationEndpoint.java @@ -156,7 +156,7 @@ public class PasskeyRegistrationEndpoint { */ @GetMapping("/list/{userId}") public ResponseEntity getUserPasskeys( - @PathVariable("userId") String userId, + @PathVariable String userId, HttpServletRequest httpRequest, HttpServletResponse httpResponse) { @@ -195,8 +195,8 @@ public class PasskeyRegistrationEndpoint { */ @DeleteMapping("/delete/{userId}/{credentialId}") public ResponseEntity deletePasskey( - @PathVariable("userId") String userId, - @PathVariable("credentialId") String credentialId, + @PathVariable String userId, + @PathVariable String credentialId, HttpServletRequest httpRequest, HttpServletResponse httpResponse) { @@ -240,7 +240,7 @@ public class PasskeyRegistrationEndpoint { */ @GetMapping("/stats/{userId}") public ResponseEntity getPasskeyStats( - @PathVariable("userId") String userId, + @PathVariable String userId, HttpServletRequest httpRequest, HttpServletResponse httpResponse) { @@ -273,7 +273,7 @@ public class PasskeyRegistrationEndpoint { */ @GetMapping("/support/{userId}") public ResponseEntity checkPasskeySupport( - @PathVariable("userId") String userId, + @PathVariable String userId, HttpServletRequest httpRequest, HttpServletResponse httpResponse) { diff --git a/maxkey-starter/maxkey-starter-social/src/main/java/org/dromara/maxkey/authn/support/socialsignon/SocialSignOnEndpoint.java b/maxkey-starter/maxkey-starter-social/src/main/java/org/dromara/maxkey/authn/support/socialsignon/SocialSignOnEndpoint.java index 69139ae5a..e35ba88fb 100644 --- a/maxkey-starter/maxkey-starter-social/src/main/java/org/dromara/maxkey/authn/support/socialsignon/SocialSignOnEndpoint.java +++ b/maxkey-starter/maxkey-starter-social/src/main/java/org/dromara/maxkey/authn/support/socialsignon/SocialSignOnEndpoint.java @@ -52,7 +52,7 @@ public class SocialSignOnEndpoint extends AbstractSocialSignOnEndpoint{ static final Logger _logger = LoggerFactory.getLogger(SocialSignOnEndpoint.class); @GetMapping("/authorize/{provider}") - public Message authorize( HttpServletRequest request,@PathVariable("provider") String provider) { + public Message authorize( HttpServletRequest request,@PathVariable String provider) { _logger.trace("SocialSignOn provider : {}" , provider); String instId = WebContext.getInst().getId(); String originURL =WebContext.getContextPath(request,false); @@ -68,7 +68,7 @@ public class SocialSignOnEndpoint extends AbstractSocialSignOnEndpoint{ } @GetMapping("/scanqrcode/{provider}") - public Message scanQRCode(HttpServletRequest request,@PathVariable("provider") String provider) { + public Message scanQRCode(HttpServletRequest request,@PathVariable String provider) { String instId = WebContext.getInst().getId(); String originURL =WebContext.getContextPath(request,false); AuthRequest authRequest = @@ -100,7 +100,7 @@ public class SocialSignOnEndpoint extends AbstractSocialSignOnEndpoint{ } @GetMapping("/bind/{provider}") - public Message bind(@PathVariable("provider") String provider, + public Message bind(@PathVariable String provider, @CurrentUser UserInfo userInfo, HttpServletRequest request) { //auth call back may exception @@ -123,7 +123,7 @@ public class SocialSignOnEndpoint extends AbstractSocialSignOnEndpoint{ } @GetMapping("/callback/{provider}") - public Message callback(@PathVariable("provider") String provider,HttpServletRequest request) { + public Message callback(@PathVariable String provider,HttpServletRequest request) { //auth call back may exception try { String originURL =WebContext.getContextPath(request,false); @@ -209,7 +209,7 @@ public class SocialSignOnEndpoint extends AbstractSocialSignOnEndpoint{ * @return */ @PostMapping("/qrcallback/{provider}/{state}") - public Message qrcallback(@PathVariable("provider") String provider,@PathVariable("state") String state, + public Message qrcallback(@PathVariable String provider,@PathVariable String state, HttpServletRequest request) { try { //判断只有maxkey扫码 diff --git a/maxkey-web-apis/maxkey-web-api-rest/src/main/java/org/dromara/maxkey/web/apis/identity/rest/RestResourcesController.java b/maxkey-web-apis/maxkey-web-api-rest/src/main/java/org/dromara/maxkey/web/apis/identity/rest/RestResourcesController.java index 14d0f97f6..a65f354df 100644 --- a/maxkey-web-apis/maxkey-web-api-rest/src/main/java/org/dromara/maxkey/web/apis/identity/rest/RestResourcesController.java +++ b/maxkey-web-apis/maxkey-web-api-rest/src/main/java/org/dromara/maxkey/web/apis/identity/rest/RestResourcesController.java @@ -58,7 +58,7 @@ public class RestResourcesController { @Operation(summary = "获取应用功能权限清单", description = "获取应用功能权限清单",method="GET") @GetMapping("/functionList") - public Message getFunctionList(@RequestParam("userId") String userId) { + public Message getFunctionList(@RequestParam String userId) { logger.debug("userId {} ", userId); UserInfo user = userInfoService.get(userId); ///获取appId登录